[libcxx-commits] [PATCH] D145881: [libc++][spaceship] Implement `operator<=>` for `duration`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D145881#4200625 <https://reviews.llvm.org/D145881#4200625>, @H-G-Hristov wrote:

> In D145881#4199876 <https://reviews.llvm.org/D145881#4199876>, @Mordante wrote:
>
>> Thanks for working on this! A few comments.
>
> Thank you for the review. I'll make sure to contact you first in the future as you recommend.
> Sorry if working on this and on `time_point` D146250 <https://reviews.llvm.org/D146250> was inappropirate.

The main thing we want to avoid is having multiple people working on the same feature.
Somethings something in the list is assigned and appears not to be moving, but there might be reasons.
For example parts of the regex spaceship I've been working on, but it was blocked.

I've not started on duration and timepoint, so feel free to implement them.

If you want to look at other things for the spaceship operator. I *think* not all items of paper P1614 <https://reviews.llvm.org/P1614> are on the list, specifically the removal of `operator!=`, which will be automatically generated.
If you want to update the status page with these missing entries it would be very much appreciated.



================
Comment at: libcxx/test/std/time/time.duration/time.duration.comparisons/compare.three_way.pass.cpp:28
+  {
+    constexpr std::chrono::seconds s1(3);
+    constexpr std::chrono::seconds s2(3);
----------------
I would remove the constexpr here, I don't think it's needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145881/new/

https://reviews.llvm.org/D145881