[libcxx-commits] [PATCH] D141222: [libc++] Use __verbose_abort instead of std::abort in __throw_ functions

[Alex Brachet via Phabricator via libcxx-commits]

abrachet added a comment.

In D141222#4197878 <https://reviews.llvm.org/D141222#4197878>, @jgorbe wrote:

> There's a comment next to the `__libcpp_verbose_abort` definition that says
>
>   // This function should never be called directly from the code -- it should only be called through
>   // the _LIBCPP_VERBOSE_ABORT macro.
>
> Does this apply here? For context, we have a libc-free project that uses variant and optional and this change pulls in vfprintf.  We'd like to just provide our own `_LIBCPP_VERBOSE_ABORT`, or build with `-D_LIBCPP_HAS_NO_VERBOSE_ABORT_IN_LIBRARY` but it doesn't look like we can do that if the code calls __libcpp_verbose_abort directly.

+1 we are running into this too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141222/new/

https://reviews.llvm.org/D141222