[libcxx-commits] [PATCH] D146190: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D146190#4199844 <https://reviews.llvm.org/D146190#4199844>, @Mordante wrote:

> I'm not really fond of declaring the MSVC ABI as unstable. If there is no other way, please add this information in the commit message. That way we can find back why it was decided to declare the ABI on a platform as unstable.

FWIW, treating the libc++ ABI as unstable in MSVC environments has been considered a couple times before, but without formally spelling it out like this. See e.g. D134912 <https://reviews.llvm.org/D134912> where we’d be more or less agreed upon the same already (even if that change hasn’t been landed yet).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146190/new/

https://reviews.llvm.org/D146190