[libcxx-commits] [PATCH] D141222: [libc++] Use __verbose_abort instead of std::abort in __throw_ functions

[Alex Langford via Phabricator via libcxx-commits]

bulbazord added a comment.
Herald added a subscriber: mikhail.ramalho.

I believe this change broke the LLDB tests. Can you please fix or revert?

Details: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52383/

  ======================================================================
  FAIL: test_dsym (TestDbgInfoContentVectorFromStdModule.TestDbgInfoContentVector)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1707, in test_method
      return attrvalue(self)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 159, in wrapper
      return func(*args, **kwargs)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 159, in wrapper
      return func(*args, **kwargs)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py", line 64, in test
      self.expect_expr("a.at(0).a", result_type="int", result_value="2")
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2463, in expect_expr
      value_check.check_value(self, eval_result, str(eval_result))
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 287, in check_value
      test_base.assertSuccess(val.GetError())
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2499, in assertSuccess
      self.fail(self._formatMessage(msg,
  AssertionError: 'expression failed to parse:
  error: Couldn't lookup symbols:
    __ZNSt3__122__libcpp_verbose_abortEPKcz
  ' is not success
  Config=x86_64-/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang
  ======================================================================
  FAIL: test_dwarf (TestDbgInfoContentVectorFromStdModule.TestDbgInfoContentVector)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1707, in test_method
      return attrvalue(self)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 159, in wrapper
      return func(*args, **kwargs)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 159, in wrapper
      return func(*args, **kwargs)
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py", line 64, in test
      self.expect_expr("a.at(0).a", result_type="int", result_value="2")
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2463, in expect_expr
      value_check.check_value(self, eval_result, str(eval_result))
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 287, in check_value
      test_base.assertSuccess(val.GetError())
    File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2499, in assertSuccess
      self.fail(self._formatMessage(msg,
  AssertionError: 'expression failed to parse:
  error: Couldn't lookup symbols:
    __ZNSt3__122__libcpp_verbose_abortEPKcz
  ' is not success
  Config=x86_64-/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang
  ----------------------------------------------------------------------


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141222/new/

https://reviews.llvm.org/D141222