[libcxx-commits] [PATCH] D145976: [libc++][spaceship] Implement `operator<=>` for `map` and `multimap`

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/libcxx/containers/associative/map/compare.three_way.pass.cpp:26
+  assert(test_ordered_map_container_spaceship<std::map>());
+  // `std::map` is not constexpr, so no `static_assert` test here.
+  return 0;
----------------
H-G-Hristov wrote:
> H-G-Hristov wrote:
> > philnik wrote:
> > > Most of the tests don't have a `constexpr` path. There is no need to call it out here.
> > I kept this pattern from the original patch here: https://reviews.llvm.org/D132312
> > Shall I delete it now or create a new patch later to delete this line from all patches at once?
> What I mean it is already present in patches that have landed but also in all that are waiting for a review.
Ah OK. I missed that this already exists in other `operator<=>` patches. Then I'm fine with it as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145976/new/

https://reviews.llvm.org/D145976