[libcxx-commits] [PATCH] D145976: [libc++][spaceship] Implement `operator<=>` for `map` and `multimap`

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 14 14:54:05 PDT 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nit.



================
Comment at: libcxx/test/libcxx/containers/associative/map/compare.three_way.pass.cpp:26
+  assert(test_ordered_map_container_spaceship<std::map>());
+  // `std::map` is not constexpr, so no `static_assert` test here.
+  return 0;
----------------
Most of the tests don't have a `constexpr` path. There is no need to call it out here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145976/new/

https://reviews.llvm.org/D145976



More information about the libcxx-commits mailing list