[libcxx-commits] [PATCH] D145981: [libc++] Assert that lengths fit in difference_type

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for your contribution, a few comments.



================
Comment at: libcxx/test/libcxx/strings/string.view/assert.ctor.length.pass.cpp:10-12
+// UNSUPPORTED: c++11, c++14
+
+// UNSUPPORTED: c++03
----------------
Why is this not supported in these language versions? We have enabled `string_view` in older language versions.


================
Comment at: libcxx/test/libcxx/strings/string.view/assert.ctor.length.pass.cpp:15
+// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ENABLE_ASSERTIONS=1
+
+#include <string_view>
----------------
Please add the function's synopsis here, best look for other tests for examples.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145981/new/

https://reviews.llvm.org/D145981