[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

Tom Honermann via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 14 10:28:35 PDT 2023


tahonermann added inline comments.


================
Comment at: libcxx/stdmodules/std-cstddef.cppm:13
+#include <cstddef>
+
+export module std:cstddef;
----------------
ldionne wrote:
> Would this make sense to avoid users having to define all the config site macros? `#include <__config_site>`
Named modules don't export/leak macros when imported, so the addition of the `#include` would have no effect on importers of the module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994



More information about the libcxx-commits mailing list