[libcxx-commits] [PATCH] D145590: [libc++][charconv] Granularizes the header.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 14 10:12:07 PDT 2023


Mordante marked 2 inline comments as done.
Mordante added a comment.

In D145590#4193285 <https://reviews.llvm.org/D145590#4193285>, @ldionne wrote:

> LGTM -- I am fine with either splitting the floating point `to_chars` and the integral ones or not splitting them. I think the current approach with a combined header that includes the floating-point/integral headers is a fine compromise.

Thanks for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145590/new/

https://reviews.llvm.org/D145590



More information about the libcxx-commits mailing list