[libcxx-commits] [PATCH] D145691: [libc++] Remove ext/* headers from tests

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I really would like a better rationale for removing these test. Since the are not very actively maintained I really dislike the idea to remove regression tests.



================
Comment at: libcxx/test/libcxx/assertions/headers_declare_verbose_abort.sh.cpp:45
-// Prevent <ext/hash_map> from generating deprecated warnings for this test.
-#if defined(__DEPRECATED)
-#   undef __DEPRECATED
----------------
Why not silence this warning for this test instead of removing the tests.
The ext headers may not get a lot of attention, but removing tests may cause accidental regressions not being detected.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145691/new/

https://reviews.llvm.org/D145691