[libcxx-commits] [PATCH] D126122: Fix RUNPATH not accounting for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

In D126122#4173881 <https://reviews.llvm.org/D126122#4173881>, @arcivanov wrote:

> @daltenty I applied the same exclusion logic `llvm_setup_rpath` in AddLLVM.cmake and the build is now fully passing.

Thanks. I think the AIX exclude part should be fine, we can worry about fixing this if the AIX loader ever gets the required feature.

> I could take the same approach as `llvm_setup_rpath` with INSTALL_RPATH and BUILD_WITH_INSTALL_RPATH if you prefer.

Yeah, I think as @phosek suggests, it would be better is we set the right `BUILD_RPATH` and `INSTALL_RPATH` properties for the shared library targets, so we avoid manually pushing the linker opts.

Seems like we might need to add something, as these properties don't seem like they're currently used in the runtime side. Maybe we could create `LIBCXX_INSTALL_RPATH` and `LIBCXX_BUILD_RPATH`  and similar variables and use those to create the properties (something like that might be generally useful for manipulating the load paths).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126122/new/

https://reviews.llvm.org/D126122