[libcxx-commits] [PATCH] D144640: [libc++] Run modules_include.sh.cpp compiles in parallel

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/modules_include.sh.cpp:40
+  print("// {}: bash -c 'echo \"TEST_{}=\\$!\"' >> %t.sh".format('RUN', i))
+  if i >= 16:
+    print("// {}: echo \"wait $TEST_{}\" >> %t.sh".format('RUN', i - 16))
----------------
philnik wrote:
> Mordante wrote:
> > Can you limit this to the number of cores on the system, for example, by using `nproc`? 
> I'm not sure how I would do that without building a thread pool. Just the number of cores doesn't really help. At that point it's probably easier to integrate with lit.
Then please use a way with lit, this test now uses a lot of resources on machines with less than 16 cores.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144640/new/

https://reviews.llvm.org/D144640