[libcxx-commits] [PATCH] D145596: [runtimes] Fixes building with CMake 3.26.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: runtimes/CMakeLists.txt:147
 endif()
+# When present, the -nostdinc++ flag gets propagated to the linker flags. In
+# CMake 3.26 this causes try_compile to fail for other compile options. Which
----------------
ldionne wrote:
> I think it would be really nice to instead avoid passing `-nostdinc++` to the linker when we don't mean it. That would require a bit of reworking of how we detect compiler options, but that might be a good idea nonetheless. Thoughts?
I initially looked at that solution, but based on the documentation there's no real option for that
https://cmake.org/cmake/help/latest/module/CheckCSourceCompiles.html

Do you have a suggestion how to achieve that solution?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145596/new/

https://reviews.llvm.org/D145596