[libcxx-commits] [PATCH] D145691: [libc++][NFC] Use -Wno-deprecated instead of undefining __DEPRECATED

John Brawn via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 9 07:34:35 PST 2023


john.brawn created this revision.
john.brawn added a reviewer: libc++.
Herald added a project: All.
john.brawn requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Several tests undefine __DEPRECATED to avoid warnings as they're testing the deprecated ext/hash_map. A better way to do this is to use -Wno-deprecated so it isn't defined in the first place. This prevents these tests from failing when we give a warning on undefining a predefined macro, as D144654 <https://reviews.llvm.org/D144654> will do.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145691

Files:
  libcxx/test/libcxx/assertions/headers_declare_verbose_abort.sh.cpp
  libcxx/test/libcxx/clang_tidy.sh.cpp
  libcxx/test/libcxx/containers/gnu_cxx/hash_map.pass.cpp
  libcxx/test/libcxx/containers/gnu_cxx/hash_map_name_lookup.pass.cpp
  libcxx/test/libcxx/containers/gnu_cxx/hash_set.pass.cpp
  libcxx/test/libcxx/containers/gnu_cxx/hash_set_name_lookup.pass.cpp
  libcxx/test/libcxx/double_include.sh.cpp
  libcxx/test/libcxx/extensions/hash/specializations.pass.cpp
  libcxx/test/libcxx/min_max_macros.compile.pass.cpp
  libcxx/test/libcxx/modules_include.sh.cpp
  libcxx/test/libcxx/nasty_macros.compile.pass.cpp
  libcxx/test/libcxx/no_assert_include.compile.pass.cpp
  libcxx/test/libcxx/transitive_includes.sh.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145691.503765.patch
Type: text/x-patch
Size: 6778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230309/a3c9c725/attachment-0001.bin>


More information about the libcxx-commits mailing list