[libcxx-commits] [PATCH] D145320: [libc++] Granularize <type_traits> includes

[Mikael Holmén via Phabricator via libcxx-commits]

uabelho added a comment.

In D145320#4180718 <https://reviews.llvm.org/D145320#4180718>, @uabelho wrote:

> Is it only me that see problems like
>
>   ******************** TEST 'llvm-libc++-shared.cfg.in :: libcxx/transitive_includes.sh.cpp' FAILED ********************
>
> with this patch?
>
> I get
>
>   $ ":" "RUN: at line 557"
>   note: command had no output on stdout or stderr
>   $ "diff" "-w" "/repo/uabelho/dev-main/libcxx/test/libcxx/transitive_includes/cxx2b.csv" "/repo/uabelho/dev-main/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/test/libcxx/Output/transitive_includes.sh.cpp.dir/t.tmp/transitive_includes.csv"
>   # command output:
>   *** /repo/uabelho/dev-main/libcxx/test/libcxx/transitive_includes/cxx2b.csv
>   --- /repo/uabelho/dev-main/llvm/build-all-builtins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/test/libcxx/Output/transitive_includes.sh.cpp.dir/t.tmp/transitive_includes.csv
>   ***************
>   *** 245,251 ****
>     formatstring
>     formatstring_view
>     formattuple
>   - formattype_traits
>     formatvector
>     formatversion
>     forward_listcompare
>   --- 245,250 ----
>   
>   error: command failed with exit status: 1

Seems to be fixed in https://reviews.llvm.org/D145651


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145320/new/

https://reviews.llvm.org/D145320