[libcxx-commits] [PATCH] D136765: [ASan][libcxx] Annotating std::vector with all allocators

[Hans Wennborg via Phabricator via libcxx-commits]

hans added a comment.

In D136765#4179911 <https://reviews.llvm.org/D136765#4179911>, @AdvenamTacet wrote:

> This update includes change from D145628 <https://reviews.llvm.org/D145628> and adds an easy way to turn off annotations for a specific allocator.
> It also adds a test for that change, based on failing example showed above.
>
> I still consider unpoisoning memory as a superior choice, but if it's impossible in some situations (like using allocator mantained by someone else), now it should be easy to turn off annotations for a specific allocator.

Thanks! I added a comment on that. Besides allocators maintained by someone else, I think https://crbug.com/1420967 is also a good example of where unpoisoning isn't an option.

The current patch still has the `_LIBCPP_CLANG_VER` issue though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136765/new/

https://reviews.llvm.org/D136765