[libcxx-commits] [PATCH] D145492: [libcxxabi][Demangle] Don't drop ctor/dtor name for abi-tagged structures

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks for the catch, this makes sense to me!

In D145492#4177344 <https://reviews.llvm.org/D145492#4177344>, @Michael137 wrote:

> Want me to merge the two commits into a single revision/commit? Or move the test to the LLVM diff?

FWIW, no strong opinion here but I think it would make sense to apply the changes to both directories in the same patch. You may want to sync it once before your patch if it's out-of-date right now as a NFC, just so that this patch stays consistent.



================
Comment at: llvm/test/tools/llvm-cxxfilt/abitag.test:7
+CHECK-NEXT: global[abi:Tag]::global()
+CHECK-NEXT: global[abi:Tag]::~global()
----------------
Would it make sense to add a test to `libcxxabi/test/test_demangle.pass.cpp` as well? I think that's where those are usually added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145492/new/

https://reviews.llvm.org/D145492