[libcxx-commits] [PATCH] D145589: [libc++] Make std::allocator_arg and friends conforming in C++17

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

Thanks for working on this! This makes helps to enable modules in libc++.

LGTM, but I really would like to use a helper macro over `#ifdef`s.



================
Comment at: libcxx/include/__functional/bind.h:67
+#elif _LIBCPP_STD_VER >= 17
+inline constexpr __ph<1>   _1{};
+inline constexpr __ph<2>   _2{};
----------------
I thought you had a marco `_LIBCPP_INLINE_CONSTEXPR_VAR` in a different patch, that could be sued here too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145589/new/

https://reviews.llvm.org/D145589