[libcxx-commits] [PATCH] D144575: [libc++][CI] Improves Dockerfile

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 3 inline comments as done.
Mordante added a comment.

Thanks for the review. I will basically revert these changes and only remove the unneeded package and the apt removal.



================
Comment at: libcxx/utils/ci/Dockerfile:67-71
+    # previous release
+    bash /tmp/llvm.sh $(($LLVM_HEAD_VERSION - 2)) && \
+    # latest release
+    bash /tmp/llvm.sh $(($LLVM_HEAD_VERSION - 1)) && \
+    # current ToT
----------------
philnik wrote:
> Mordante wrote:
> > philnik wrote:
> > > 
> > I like to keep the comments for clarity.
> I really don't see how describing what the lines do on-by-one help in any way. They just make it harder to read IMO.
As discussed with Louis this entire hunk will be reverted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144575/new/

https://reviews.llvm.org/D144575