[libcxx-commits] [PATCH] D136765: [ASan][libcxx] Annotating std::vector with all allocators

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D136765#4178231 <https://reviews.llvm.org/D136765#4178231>, @hans wrote:

> In D136765#4178156 <https://reviews.llvm.org/D136765#4178156>, @philnik wrote:
>
>> The last two official releases. It doesn't seem like ChromeOS uses that, given that LLVM16 isn't released yet. Anyways, I think we have to revert, since we clearly need some way to fix the annotation problems, and that will probably take some time to figure out.
>
> FWIW I think just checking `_LIBCPP_CLANG_VER >= 1700` would be a good fix.

I don't think that makes sense. We don't check that we have the version after the first one in which it's implemented anywhere else. Supporting this kind of stuff would be a nightmare, and 99% of people who don't use an official release are either on the bleeding edge, or are a vendor. If you are a vendor you probably have some downstream patches anyways, so having this too seems not that much of a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136765/new/

https://reviews.llvm.org/D136765