[libcxx-commits] [PATCH] D136765: [ASan][libcxx] Annotating std::vector with all allocators

[Manoj Gupta via Phabricator via libcxx-commits]

manojgupta added subscribers: ldionne, manojgupta.
manojgupta added a comment.

In D136765#4178089 <https://reviews.llvm.org/D136765#4178089>, @hans wrote:

> In D136765#4173661 <https://reviews.llvm.org/D136765#4173661>, @ayzhao wrote:
>
>> FYI this is causing (yet another) bug on Chrome/Chrome OS: https://crbug.com/1422033
>
> We've root caused this to ChromeOS using a toolchain based on llvmorg-16-init-6711-g11897708c022, which is before the ASan runtime gained support for unaligned container memory in llvmorg-16-init-9006-gdd1b7b797a11, which this patch depends on. (https://crbug.com/1422033#c11 has a reproducer).
>
> I see that the patch is already trying to handle this with the `#if _LIBCPP_CLANG_VER >= 1600` check. However, that doesn't quite work since there were many revisions with that version number before the ASan change.
>
> Should it be checking `_LIBCPP_CLANG_VER >= 1700` instead, or is there some more precise way to handle this? (Does the ASan runtime have some way to check if it supports this for example?)

Afaik, this is against libc++ policy. libc++ needs to work with at least 1 or 2 last clang releases so this patch needs to accomodate it.
@ldionne to confirm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136765/new/

https://reviews.llvm.org/D136765