[libcxx-commits] [PATCH] D145492: [libcxxabi][Demangle] Don't drop ctor/dtor name for abi-tagged structures

Wed Mar 8 01:00:23 PST 2023

jhenderson requested changes to this revision.
jhenderson added a comment.
This revision now requires changes to proceed.

Your test is failing the pre-merge checks.

================
Comment at: llvm/test/tools/llvm-cxxfilt/abitag.test:1
-RUN: llvm-cxxfilt -n _Z14returns_stringB5cxx11v _Z6globalB5cxx11 _Z6globalB12a_longer_tag | FileCheck %s
+RUN: llvm-cxxfilt -n _Z14returns_stringB5cxx11v _Z6globalB5cxx11 _Z6globalB12a_longer_tag _ZN6globalB3TagC2Ev _ZN6globalB3TagD2Ev | FileCheck %s

----------------
This test is testing llvm-cxxfilt, but llvm-cxxfilt doesn't use the libcxxabi code. It uses the demangler code in libDemangle, so it's not surprising it fails.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145492/new/

https://reviews.llvm.org/D145492