[libcxx-commits] [PATCH] D144568: [libc++][NFC] Refactor the __enable_ifs in <string>

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 7 13:56:34 PST 2023


EricWF added a comment.

@philnik Every single change needs a description.  The description must include the motivation for making the change. What does in improve? What code does it break/fix? etc.

This is important for review, and its even more important down the road when we're trying to figure out why a particular change was made all that time ago.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144568/new/

https://reviews.llvm.org/D144568



More information about the libcxx-commits mailing list