[libcxx-commits] [PATCH] D145520: [libc++][test] Uses qualified std::uint32_t.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D145520#4175977 <https://reviews.llvm.org/D145520#4175977>, @philnik wrote:

> Is there a reason you don't qualify all the integer aliases in a single patch? Also, should we maybe start to enforce a few clang-tidy checks on the tests, so we can avoid regressing on this? It's probably not too hard to add a check.

Mark and I discussed this offline and we decided to start with a small patch to evaluate how that was going to behave with downstream merging. Other patches will touch things like `size_t` (so 1000+ files in the test suite). Seeing the reasonable impact of this one, I wouldn't be opposed to doing this for other types like `int64_t` & friends in this patch, if it keeps the scope similar. But I'm also OK with separate patches.



================
Comment at: libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/minus1.pass.cpp:19
 // operator<<( int32_t val);
-// operator<<(uint32_t val);
+// operator<<(std::uint32_t val);
 // operator<<( int64_t val);
----------------
Technically, I think this doesn't need to change since the synopsis in the standard is based on the fact that we're already inside namespace `std`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145520/new/

https://reviews.llvm.org/D145520