[libcxx-commits] [PATCH] D145520: [libc++][test] Uses qualified std::uint32_t.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/libcxx/type_traits/convert_to_integral.pass.cpp:97
   // On some platforms, unsigned int and long are the same size.  These
-  // platforms have a choice of making uint32_t an int or a long.  However
+  // platforms have a choice of making std::uint32_t an int or a long.  However
   // char32_t must promote to an unsigned int on these platforms [conv.prom].
----------------
Comments are not really required, but since the conversion will be quite some work I prefer to make no exception for the comments.


================
Comment at: libcxx/test/std/atomics/atomics.types.generic/integral.pass.cpp:191
     test<std::atomic_int32_t,   int32_t>();
-    test<std::atomic_uint32_t, uint32_t>();
+    test<std::atomic_uint32_t, std::uint32_t>();
     test<std::atomic_int64_t,   int64_t>();
----------------
I thought I had reverted this change locally, but seems I didn't.


================
Comment at: libcxx/test/std/atomics/types.pass.cpp:145
     test< int32_t> ();
-    test<uint32_t> ();
+    test<std::uint32_t> ();
     test< int64_t> ();
----------------
I didn't fix the alignment:
* it will correct itself in this case when the other types are done.
* I really don't want to manually format over 1000 places manually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145520/new/

https://reviews.llvm.org/D145520