[libcxx-commits] [PATCH] D144286: [libc++][format] Addresses LWG3839.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/docs/Status/Cxx2bIssues.csv:259
 "`3820 <https://wg21.link/LWG3820>`__","``cartesian_product_view::iterator::prev`` is not quite right","February 2023","","","|ranges|"
 "`3825 <https://wg21.link/LWG3825>`__","Missing compile-time argument ``id`` check in ``basic_format_parse_context::next_arg_id``","February 2023","","","|format|"
 "`3204 <https://wg21.link/LWG3204>`__","``sub_match::swap`` only swaps the base class","February 2023","","",""
----------------
Commit message typo: sequenences


================
Comment at: libcxx/test/std/utilities/format/format.tuple/set_separator.pass.cpp:41-42
   formatter.set_separator(SV("sep"));
+  // Note the SV macro may throw, so can't use it.
+  static_assert(noexcept(formatter.set_separator(std::basic_string_view<CharT>{})));
 
----------------
You could use `declval()` and perhaps remove the comment about the `SV` macro (here and everywhere else)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144286/new/

https://reviews.llvm.org/D144286