[libcxx-commits] [PATCH] D144575: [libc++][CI] Improves Dockerfile

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

As discussed, I am not sure this actually solves a problem we encounter -- our image isn't that large and I don't think the image download times have been a problem. If that's incorrect, please LMK since that changes my opinion about this patch.

But assuming that we're not really gaining something noticeable in terms of speed/size, IMO this patch is a small net loss since it's a bit less readable than what we had before. This is a part of our CI infrastructure and IMO we should strive to keep it as simple as possible to keep the barrier for people maintaining it as low as possible -- to me that has more value than a bit more size in the image.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144575/new/

https://reviews.llvm.org/D144575