[libcxx-commits] [PATCH] D144255: [libc++] Granularize <atomic> includes

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision as: ldionne.
ldionne added a comment.

LGTM w/ passing CI.



================
Comment at: libcxx/include/condition_variable:114
 #include <__mutex_base>
-#include <version>
 
----------------
Why did you remove this one?


================
Comment at: libcxx/include/condition_variable:274
 #  include <type_traits>
+#  include <version>
 #endif
----------------
And this.


================
Comment at: libcxx/include/ios:232
 #if !defined(_LIBCPP_HAS_NO_ATOMIC_HEADER)
-#include <atomic>     // for __xindex_
+#  include <__atomic/atomic.h>
 #endif
----------------
Let's keep the `for __xindex_` comment, since it seems like this is only used in 1 place


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144255/new/

https://reviews.llvm.org/D144255