[libcxx-commits] [PATCH] D144362: [libcxx] Updated <experimental/simd> based on Parallelism-TS N4808

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:787
   cwchar
   cwctype
   deque
----------------
I think it would be good to add a status paper, so it's easier to see what it already implemented and what you want to implement in a particular patch. I'd be fine with just having the big groups in it for now and split them up as we implement more. You can look at `libcxx/docs/Status/Zip{.rst,Projects.csv}` for an example.
This should be a good start:
```
Section,Description,Dependencies,Assignee,Complete
| [parallel.exceptions], "Parallel Exceptions", None, unassigned, |Not Started|
| [parallel.execpol], "Execution policies", None, unassigned, |Not Started|
| [parallel.alg], "Parallel algorithms", None, unassigned, |Not Started|
| [parallel.taskblock], "Task Block", None, unassigned, |Not Started|
| [parallel.simd.abi], "simd ABI tags", None, unassigned, |Not Started|
| [parallel.simd.traits], "simd type traits", None, unassigned, |Not Started|
| [parallel.simd.whereexpr], "Where expression class templates", None, unassigned, |Not Started|
| [parallel.simd.class], "Class template simd", None, unassigned, |Not Started|
| [parallel.simd.nonmembers], "simd non-member operations", None, unassigned, |Not Started|
| [parallel.simd.mask.class], "Reductions", None, unassigned, |Not Started|
| [parallel.simd.mask.nonmembers], "Non-member operations", None, unassigned, |Not Started|
```



================
Comment at: libcxx/include/experimental/simd:59-60
+#include <experimental/__simd/vec_ext.h>
+#include <type_traits>
+#include <utility>
+
----------------
Please use the granularized headers.


================
Comment at: libcxx/include/experimental/simd:68
+
+_LIBCPP_BEGIN_NAMESPACE_EXPERIMENTAL
+inline namespace parallelism_v2 {
----------------
Since this is all new code, please clang-format the whole file.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:37-52
+  test_all_simd_abi<F, long double>(integer_seq_from_make_integer);
+  test_all_simd_abi<F, double>(integer_seq_from_make_integer);
+  test_all_simd_abi<F, float>(integer_seq_from_make_integer);
+  test_all_simd_abi<F, long long>(integer_seq_from_make_integer);
+  test_all_simd_abi<F, unsigned long long>(integer_seq_from_make_integer);
+  test_all_simd_abi<F, long>(integer_seq_from_make_integer);
+  test_all_simd_abi<F, unsigned long>(integer_seq_from_make_integer);
----------------
We have `libcxx/test/support/type_algorithms.h` to help with this kind of stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144362/new/

https://reviews.llvm.org/D144362