[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__compare/synth_three_way.h:31
+// Possible fix https://reviews.llvm.org/D140002
+#if 0
 _LIBCPP_HIDE_FROM_ABI inline constexpr auto __synth_three_way =
----------------
philnik wrote:
> IMO the new code is cleaner anyways, so we might as well change it. I actually had this on my TODO list for quite a while.
I can make a separate review for it. The other change is `inline constexpr` for variables for which Louis has a patch. And you had a patch to remove `static` from `_LIBCPP_HIDE_FROM_ABI static constexpr`, which for now are most of the library changes required,

(There is an issue with not being able to use ranges too, but I haven't investigated that yet.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994