[libcxx-commits] [PATCH] D143850: [libc++][format] Addresses LWG3833.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/docs/ReleaseNotes.rst:66
 
+- The formatter specialization ``template<size_t N> struct formatter<const charT[N], charT>``
+  has been removed. Since libc++'s format library was marked experimental there
----------------
ldionne wrote:
> Can you comment on how (if at all) this impacts users in the release note? Also, perhaps "Deprecations and Removals" would be a better section for this release note?
I moved it. I don't expect anybody to be affected. I only affects people instantiating this specialization either directly or by inheritance. Direct specialization is extremely rare, typically formatters are used from the format functions. Inheriting itself is not rare, but the specialization for a `basic_string`, `basic_string_view`, or even `const CharT*` are more likely candidates for a base class for a custom string-like formatter.

If you want I can add more comment, but I think in this case it's not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143850/new/

https://reviews.llvm.org/D143850