[libcxx-commits] [PATCH] D144277: [libc++][format] Addresses LWG3881.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 3 12:07:08 PST 2023


ldionne added inline comments.


================
Comment at: libcxx/include/__format/container_adaptor.h:42
+  using __maybe_const_adaptor   = __maybe_const<is_const_v<__maybe_const_container>, _Adaptor>;
+  formatter<ranges::ref_view<__maybe_const_container>, _CharT> __underlying_;
 
----------------
Any reason why you're using `ref_view` instead of `all_t`? Those are not always equivalent -- is the difference not relevant?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144277/new/

https://reviews.llvm.org/D144277



More information about the libcxx-commits mailing list