[libcxx-commits] [PATCH] D144821: [libc++][spaceship] Implement `operator<=>` for `deque`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 1 10:52:48 PST 2023


Mordante accepted this revision.
Mordante added a comment.

In D144821#4161664 <https://reviews.llvm.org/D144821#4161664>, @philnik wrote:

> In D144821#4161020 <https://reviews.llvm.org/D144821#4161020>, @H-G-Hristov wrote:
>
>> 

not necessarily the case, so you might have to add people.

>> 2. If this patch passes the review successfully, would you mind if I try completing some of the other containers too?
>
> Feel free to do so, but make sure there isn't a patch already (AFAICT for spaceship there is only for `array` and `vector` a patch). More contributors are always welcome.

Feel free to pick the items that are unassigned. When you want to pick an assigned item, best discuss on Discord. Some of the assigned items may have a patch already.

Thanks for your contribution, LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144821/new/

https://reviews.llvm.org/D144821



More information about the libcxx-commits mailing list