[libcxx-commits] [PATCH] D144915: [libc++] Fix modules issues on OS X

Wed Mar 1 09:09:53 PST 2023

Mordante added a comment.

In D144915#4159876 <https://reviews.llvm.org/D144915#4159876>, @ldionne wrote:

> In D144915#4159110 <https://reviews.llvm.org/D144915#4159110>, @Mordante wrote:
>
>> Mainly curios, but how do curses get pulled into our tests?
>
> I think this is via Apple's SDK, which seem to provide ncurses. This is arguably not very clean.

Interesting.

>> Could we maybe get a modules build on macOS, since it seems there are some pretty horrible things inside the system headers? Who thought it would be a good idea to reserve `Point`? I think Android has a few horrific things in the system headers too, but there we don't have any CI currently.
>
> That's a good idea, adding one.

I really like this, thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144915/new/

https://reviews.llvm.org/D144915