[libcxx-commits] [PATCH] D135248: [libc++] implement move_iterator<T*> should be a random access iterator

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.

LGTM % comments.



================
Comment at: libcxx/docs/ReleaseNotes.rst:40-41
 ------------------
+- P2520R0 - ``move_iterator<T*>`` should be a random access iterator
 
 - P1328R1 - ``constexpr type_info::operator==()``
----------------



================
Comment at: libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/types.pass.cpp:102
 #if TEST_STD_VER > 17
-  static_assert(std::is_same_v<typename R::iterator_concept, std::input_iterator_tag>);
+  static_assert(std::is_same_v<typename R::iterator_concept, typename R::iterator_category>);
 #endif
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135248/new/

https://reviews.llvm.org/D135248