[libcxx-commits] [PATCH] D145017: [libc++][libc++abi] Make libc++ includes more compatible with its own modulemap

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

Thanks for working on this! I think it would be quite nice to be able to build libc++ with modules enabled, but I'm not sure it will actually be possible, since we define some classes differently in the source files to provide old symbols.



================
Comment at: libcxx/src/filesystem/operations.cpp:17
 #include <type_traits>
+#include <utility>
 #include <vector>
----------------
I don't think we want to do this. In fact, we should go the other way and use private headers instead IMO. Instead, we should pass `-fmodule-name=std` to let clang know that these files implement the module.


================
Comment at: libcxx/test/libcxx/transitive_includes/cxx2b.csv:165
 expected version
+experimental/algorithm algorithm
+experimental/algorithm cstddef
----------------
This seems wrong. Maybe a broken rebase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145017/new/

https://reviews.llvm.org/D145017