[libcxx-commits] [PATCH] D142993: [libcxx] Add _LIBCPP_NODEBUG to global std::ranges::__cpo variables

[Michael Buch via Phabricator via libcxx-commits]

Michael137 added a comment.

In D142993#4159548 <https://reviews.llvm.org/D142993#4159548>, @ldionne wrote:

> This LGTM since it makes the status quo better. I would suggest we make this change right now, and if we need to use a different approach to fix the expression evaluator in the future, then we can cross that bridge when we get to it. But as far as we're concerned right now, this seems to be a pure improvement over the status quo.
>
> Can you please rebase onto `main`? Once this is merged, we will also want to cherry-pick onto `release/16.x`.

@ldionne Thanks for the review

Just to clarify, if we want to get expression evaluation to work we will have to remove these attributes again, since calling these function objects requires debug-info for these variables to be present. But that feature will take some time to complete and is unlikely to make it into this release. So if we're fine with the churn for the immediate benefit then I'll go ahead and land this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142993/new/

https://reviews.llvm.org/D142993