[libcxx-commits] [PATCH] D144821: [libc++][spaceship] Implement `operator<=>` for `deque`

[Hristo Hristov via Phabricator via libcxx-commits]

H-G-Hristov marked 3 inline comments as done.
H-G-Hristov added a comment.

In D144821#4156977 <https://reviews.llvm.org/D144821#4156977>, @avogelsgesang wrote:

> Thanks for this change!
>
> In general, I won't be able to approve your commit for the `libc++` group. In the end, you will need the review from one of the "core libc++ contributors" (e.g., @Mordante) to ship this fix.
>
> Also, for "stacked commits", i.e. commits which depend on other changes which didn't land on `main`, yet, you need to add a parent revision here on Phabricator. I did this for you already and also restarted the CI job. So this is just for future reference :)
>
> Please also update `libcxx/docs/Status/SpaceshipProjects.csv`

Thank you very much for the review and the notes and of course for completing the real work previously. I wanted to try out the process of submitting a patch.

A have a couple of questions:

1. Do I need to add anyone specific as a reviewer, message/ask somebody or I should just wait.
2. If this patch passes the review successfully, would you mind if I try completing some of the other containers too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144821/new/

https://reviews.llvm.org/D144821