[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/utils/ci/BOT_OWNERS.txt:13
 E: linaro-toolchain at lists.linaro.org
-D: Armv7, Armv8, AArch64
+D: Armv6-M, Armv7, Armv8, AArch64
 
----------------
Maybe just make this "Arm platforms" or something like that? It's not like it makes a difference which architectures specifically are supported.


================
Comment at: libcxx/utils/ci/run-buildbot:606
 ;;
+armv6m-picolibc)
+    clean
----------------
I would encourage you to also enable clang-tidy, since this tests a configuration with custom code paths, but that's not a must if it's too hard to do.


================
Comment at: libcxx/utils/ci/run-buildbot:615-616
+          -DCMAKE_CXX_FLAGS="${flags}" \
+          -DCMAKE_C_COMPILER=clang \
+          -DCMAKE_CXX_COMPILER=clang++ \
+          -DLIBCXX_ENABLE_WERROR=NO
----------------
These should be set through the environment variable and not be hard-coded.


================
Comment at: libcxx/utils/ci/run-buildbot:617
+          -DCMAKE_CXX_COMPILER=clang++ \
+          -DLIBCXX_ENABLE_WERROR=NO
+
----------------
Why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246