[libcxx-commits] [PATCH] D153216: [libc++][Modules] Add missing includes to public headers

[Ian Anderson via Phabricator via libcxx-commits]

iana added inline comments.


================
Comment at: libcxx/include/algorithm:1747
 #include <__algorithm/all_of.h>
 #include <__algorithm/any_of.h>
 #include <__algorithm/binary_search.h>
----------------
EricWF wrote:
> Thanks for fixing this. 
> 
> The comment below isn't about your change in particular, but rather the general structure libc++ has invented for itself recently.
> 
> I'm concerned because these are potentially fairly serious bugs, and they would never had occurred had the things in algorithm been in algorithm.
> This furthers my concern that we've invented a bunch of complexity which only debatably pulls its weight. 
> 
> I'll have to improve my understanding of the modules internals, because I'm certain we can find some ways to simplify this. 
We could probably write a unit test to verify that the public headers include all of the private headers. We already have the list in `private_headers` in `header_information.py`. We'd just have to map the __fwd headers to their public header.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153216/new/

https://reviews.llvm.org/D153216