[libcxx-commits] [PATCH] D153216: [libc++][Modules] Add missing includes to public headers

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

@ldionne @philnik

The complexity of having hundreds of headers is starting to show its head.
How do we prevent this class of bugs from continuing to occur?



================
Comment at: libcxx/include/algorithm:1747
 #include <__algorithm/all_of.h>
 #include <__algorithm/any_of.h>
 #include <__algorithm/binary_search.h>
----------------
Thanks for fixing this. 

The comment below isn't about your change in particular, but rather the general structure libc++ has invented for itself recently.

I'm concerned because these are potentially fairly serious bugs, and they would never had occurred had the things in algorithm been in algorithm.
This furthers my concern that we've invented a bunch of complexity which only debatably pulls its weight. 

I'll have to improve my understanding of the modules internals, because I'm certain we can find some ways to simplify this. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153216/new/

https://reviews.llvm.org/D153216