[libcxx-commits] [PATCH] D154017: Cleanup __uninitialized_temporary_buffer internals.

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay added inline comments.


================
Comment at: libcxx/include/new:297
 
+inline _LIBCPP_INLINE_VISIBILITY
+void *__libcpp_allocate(size_t __size, size_t __align, nothrow_t) {
----------------
ldionne wrote:
> EricWF wrote:
> > Mordante wrote:
> > > s/_LIBCPP_INLINE_VISIBILITY/_LIBCPP_HIDE_FROM_ABI/
> > Do we have a doc describing what the difference is and providing top? That way I can stop making the mistake in the future?
> From `__config`:
> 
> ```
> // Just so we can migrate to the new macros gradually.
> #  define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI
> ```
https://libcxx.llvm.org/DesignDocs/VisibilityMacros.html 

> _LIBCPP_INLINE_VISIBILITY - Historical predecessor of _LIBCPP_HIDE_FROM_ABI – please use _LIBCPP_HIDE_FROM_ABI instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154017/new/

https://reviews.llvm.org/D154017