[libcxx-commits] [PATCH] D154017: Cleanup __uninitialized_temporary_buffer internals.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 29 06:49:37 PDT 2023


ldionne added a comment.

@davidxl @mingmingl Did you folks notice the perf regression through libc++'s own benchmarks? If not, can you please share which benchmarks you used to see the difference? I'd like to add something to libc++'s benchmark suite alongside with this patch so we can have a concrete "regression test" and verify that this is making things better.



================
Comment at: libcxx/include/__memory/uninitialized_buffer.h:10
 #define _LIBCPP___MEMORY_UNINITIALIZED_BUFFER_H
 
----------------
Not attached to anything: would it be possible to upload the patch with context? This makes it easier to review. `arc diff` does that automatically, normally.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154017/new/

https://reviews.llvm.org/D154017



More information about the libcxx-commits mailing list