[libcxx-commits] [PATCH] D154017: Cleanup __uninitialized_temporary_buffer internals.

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 28 16:56:01 PDT 2023


MaskRay added a comment.

Thanks for posting the fix (the lost `!__is_overaligned_for_new` branch).

Switching to `__libcpp_allocate` removes some duplicate code, which looks good to me.

If you don't use `arc diff`, there needs to be some context. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

> uses aligned allocation when the type actually requires it. [...]

You may accidentally indent the paragraph by 4 spaces, so it was detected as a code block in Markdown.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154017/new/

https://reviews.llvm.org/D154017



More information about the libcxx-commits mailing list