[libcxx-commits] [PATCH] D154017: Cleanup __uninitialized_temporary_buffer internals.

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 28 16:44:22 PDT 2023


EricWF created this revision.
EricWF added reviewers: libc++, philnik, davidxl.
Herald added a project: All.
EricWF requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

There are a few improvements this patch makes. First, it only

  uses aligned allocation when the type actually requires it. This
  addresses a sizable user-reported performance regression in some of the
  algorithms.
  
  Second, it removes a significant amount unused template & function parameters,
  which improves code size and makes the type less error prone and more readable.
  
  And finally, it fixes a bug where operator new/delete were being called
  directly, rather than as a builtin -- preventing the compiler from
  eliding the allocation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154017

Files:
  libcxx/include/__algorithm/inplace_merge.h
  libcxx/include/__algorithm/stable_partition.h
  libcxx/include/__algorithm/stable_sort.h
  libcxx/include/__memory/uninitialized_buffer.h
  libcxx/include/new

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154017.535562.patch
Type: text/x-patch
Size: 6871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230628/16bfb413/attachment-0001.bin>


More information about the libcxx-commits mailing list