[libcxx-commits] [PATCH] D153783: [libc++] Adding mdspan layout_left

[Christian Trott via Phabricator via libcxx-commits]

crtrott marked 2 inline comments as done.
crtrott added inline comments.


================
Comment at: libcxx/include/__mdspan/layout_left.h:126
+                   "layout_left::mapping: out of bounds indexing");
+    array<index_type, extents_type::rank()> __idx_a{static_cast<index_type>(__idx)...};
+    return [&]<size_t... _Pos>(index_sequence<_Pos...>) {
----------------
ldionne wrote:
> I think we should take a look at the codegen here for small but especially for large numbers of dimensions to make sure the compiler doesn't create an actual array.
We decided to do this after the fact, lets us play on godbolt etc. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153783/new/

https://reviews.llvm.org/D153783