[libcxx-commits] [PATCH] D153991: [libc++] explicitly specialises `unique_ptr` when using `default_delete`

Wed Jun 28 13:29:42 PDT 2023

EricWF added a comment.

In D153991#4457035 <https://reviews.llvm.org/D153991#4457035>, @dblaikie wrote:

> In D153991#4456931 <https://reviews.llvm.org/D153991#4456931>, @philnik wrote:
>
>> A lot of the reduced symbols is probably the avoidance of `__compressed_pair` right now.
>
> On that note - spun off this discussion: https://discourse.llvm.org/t/reducing-overhead-of-compressed-pair/71660

Indeed. compressed pairs symbols have been a pain in our ass forever. That's a problem worth tackling , but I'm not sure it's trivial to do that.
As Philinik say, no_unique_address is a bit of a problem. But I disagree that we need it on Windows in order proceed with changes.

IMHO our user base on Windows is so small that pessimizing Windows to optimize for the masses makes sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153991/new/

https://reviews.llvm.org/D153991