[libcxx-commits] [PATCH] D153783: [libc++] Adding mdspan layout_left

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jun 28 12:20:05 PDT 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, I'll make a local check for the diff between the tests for `layout_right` and `layout_left` just in case.



================
Comment at: libcxx/test/std/containers/views/mdspan/layout_right/ctor.layout_left.pass.cpp:24
+#include <type_traits>
+#include <concepts> // what do we use from there?
+#include <cassert>
----------------
You're not using any concepts, I think this can go.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153783/new/

https://reviews.llvm.org/D153783



More information about the libcxx-commits mailing list