[libcxx-commits] [PATCH] D153991: [libc++] explicitly specialises `unique_ptr` when using `default_delete`

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

As-is this is an ABI break. Your `unique_ptr<int>` is currently 16 bytes large: https://godbolt.org/z/9xWPjTzK3. A lot of the reduced symbols is probably the avoidance of `__compressed_pair` right now. That is most likely possible to do in an ABI-stable way, but we need `no_unique_address` to work on windows for that to make sense. I'm also not convinced that duplicating the entire class is a good idea in terms of maintainability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153991/new/

https://reviews.llvm.org/D153991