[libcxx-commits] [PATCH] D141699: [libc++][ranges] Implement P2474R2(`views::repeat`).

[Yurong via Phabricator via libcxx-commits]

yronglin added inline comments.


================
Comment at: libcxx/include/__ranges/take_view.h:34
 #include <__ranges/range_adaptor.h>
+#include <__ranges/repeat_view.h>
 #include <__ranges/size.h>
----------------
yronglin wrote:
> philnik wrote:
> > philnik wrote:
> > > Let's just forward-delcare `repeat_view` instead.
> > It seems you haven't don this?
> Sorry, somehow I have missed this, I've added `__fwd/repeat_view.h` now.
@philnik I have tried to forward-declare `repeat_view` in `__fwd/repeat_view.h` before `Diff 43`, but in the standard, it uses `views::repeat` rather than `repeat_view` in `take_view.h` and `drop_view.h`, so we have to definition but not forward-declaration the `__cpo` struct in `__fwd/repeat_view.h`, and I have merged `__fwd/repeat_view.h` into the main `__ranges/repeat_view.h`. If this was not a correct approach, I'm glad to split a forward-declaration file again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141699/new/

https://reviews.llvm.org/D141699